dsmiley commented on code in PR #4862:
URL: https://github.com/apache/solr/pull/4862#discussion_r3916389794
##########
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##########
@@ -1079,6 +1045,48 @@ protected List<SolrCmdDistributor.Node>
getNodesByRoutingRules(
return nodes;
}
+ private void removeRoutingRule(String shardId, String routeKey) {
+ ReentrantLock ruleExpiryLock = req.getCore().getRuleExpiryLock();
+ if (ruleExpiryLock.isLocked()) {
+ return;
+ }
+ try {
+ if (ruleExpiryLock.tryLock(10, TimeUnit.MILLISECONDS)) {
+ log.info("Going to remove routing rule");
Review Comment:
Let's be clearer. I suggest "Removing shard update routing rule because the
target collection ____ doesn't exist".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]