zhangxinyao88 commented on code in PR #4861:
URL: https://github.com/apache/solr/pull/4861#discussion_r3910435116
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java:
##########
@@ -284,12 +318,22 @@ protected abstract static class
AsyncShardSpecificAdminRequest
protected String shard;
public AsyncShardSpecificAdminRequest(
- CollectionAction action, String collection, String shard) {
- super(action);
+ METHOD method, CollectionAction action, String collection, String
shard) {
+ super(method, action);
this.collection = checkNotNull(CoreAdminParams.COLLECTION, collection);
this.shard = checkNotNull(CoreAdminParams.SHARD, shard);
}
+ /**
+ * @deprecated Use {@link #AsyncShardSpecificAdminRequest(METHOD,
CollectionAction, String,
+ * String)}.
+ */
+ @Deprecated(since = "11.0")
+ public AsyncShardSpecificAdminRequest(
+ CollectionAction action, String collection, String shard) {
+ this(METHOD.GET, action, collection, shard);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java:
##########
@@ -78,13 +78,29 @@ public abstract class CollectionAdminRequest<T extends
CollectionAdminResponse>
protected final CollectionAction action;
+ public CollectionAdminRequest(METHOD method, CollectionAction action) {
+ this(method, "/admin/collections", action);
+ }
+
+ public CollectionAdminRequest(METHOD method, String path, CollectionAction
action) {
+ super(method, path, SolrRequestType.ADMIN);
+ this.action = checkNotNull(CoreAdminParams.ACTION, action);
+ }
+
+ /**
+ * @deprecated Use {@link #CollectionAdminRequest(METHOD, CollectionAction)}.
+ */
+ @Deprecated(since = "11.0")
public CollectionAdminRequest(CollectionAction action) {
- this("/admin/collections", action);
+ this(METHOD.GET, action);
}
+ /**
+ * @deprecated Use {@link #CollectionAdminRequest(METHOD, String,
CollectionAction)}.
+ */
+ @Deprecated(since = "11.0")
public CollectionAdminRequest(String path, CollectionAction action) {
- super(METHOD.GET, path, SolrRequestType.ADMIN);
- this.action = checkNotNull(CoreAdminParams.ACTION, action);
+ this(METHOD.GET, path, action);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java:
##########
@@ -148,8 +164,16 @@ public abstract static class AsyncCollectionAdminRequest
protected String asyncId = null;
protected boolean waitForFinalState = false;
+ public AsyncCollectionAdminRequest(METHOD method, CollectionAction action)
{
+ super(method, action);
+ }
+
+ /**
+ * @deprecated Use {@link #AsyncCollectionAdminRequest(METHOD,
CollectionAction)}.
+ */
+ @Deprecated(since = "11.0")
public AsyncCollectionAdminRequest(CollectionAction action) {
- super(action);
+ this(METHOD.GET, action);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java:
##########
@@ -334,12 +387,22 @@ protected abstract static class
CollectionAdminRoleRequest extends AsyncCollecti
protected String node;
protected String role;
- public CollectionAdminRoleRequest(CollectionAction action, String node,
String role) {
- super(action);
+ public CollectionAdminRoleRequest(
+ METHOD method, CollectionAction action, String node, String role) {
+ super(method, action);
this.role = checkNotNull(CollectionAdminParams.ROLE, role);
this.node = checkNotNull(CoreAdminParams.NODE, node);
}
+ /**
+ * @deprecated Use {@link #CollectionAdminRoleRequest(METHOD,
CollectionAction, String,
+ * String)}.
+ */
+ @Deprecated(since = "11.0")
+ public CollectionAdminRoleRequest(CollectionAction action, String node,
String role) {
+ this(METHOD.GET, action, node, role);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java:
##########
@@ -527,17 +533,33 @@ public SolrParams getParams() {
public static class ListSnapshots extends CoreAdminRequest {
public ListSnapshots() {
- super();
+ super(METHOD.GET);
this.action = CoreAdminAction.LISTSNAPSHOTS;
}
}
+ public CoreAdminRequest(METHOD method) {
+ this(method, "/admin/cores");
+ }
+
+ public CoreAdminRequest(METHOD method, String path) {
+ super(method, path, SolrRequestType.ADMIN);
+ }
+
+ /**
+ * @deprecated Use {@link #CoreAdminRequest(METHOD)}.
+ */
+ @Deprecated(since = "11.0")
public CoreAdminRequest() {
- super(METHOD.GET, "/admin/cores", SolrRequestType.ADMIN);
+ this(METHOD.GET);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java:
##########
@@ -78,13 +78,29 @@ public abstract class CollectionAdminRequest<T extends
CollectionAdminResponse>
protected final CollectionAction action;
+ public CollectionAdminRequest(METHOD method, CollectionAction action) {
+ this(method, "/admin/collections", action);
+ }
+
+ public CollectionAdminRequest(METHOD method, String path, CollectionAction
action) {
+ super(method, path, SolrRequestType.ADMIN);
+ this.action = checkNotNull(CoreAdminParams.ACTION, action);
+ }
+
+ /**
+ * @deprecated Use {@link #CollectionAdminRequest(METHOD, CollectionAction)}.
+ */
+ @Deprecated(since = "11.0")
public CollectionAdminRequest(CollectionAction action) {
- this("/admin/collections", action);
+ this(METHOD.GET, action);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java:
##########
@@ -527,17 +533,33 @@ public SolrParams getParams() {
public static class ListSnapshots extends CoreAdminRequest {
public ListSnapshots() {
- super();
+ super(METHOD.GET);
this.action = CoreAdminAction.LISTSNAPSHOTS;
}
}
+ public CoreAdminRequest(METHOD method) {
+ this(method, "/admin/cores");
+ }
+
+ public CoreAdminRequest(METHOD method, String path) {
+ super(method, path, SolrRequestType.ADMIN);
+ }
+
+ /**
+ * @deprecated Use {@link #CoreAdminRequest(METHOD)}.
+ */
+ @Deprecated(since = "11.0")
public CoreAdminRequest() {
- super(METHOD.GET, "/admin/cores", SolrRequestType.ADMIN);
+ this(METHOD.GET);
}
+ /**
+ * @deprecated Use {@link #CoreAdminRequest(METHOD, String)}.
+ */
+ @Deprecated(since = "11.0")
public CoreAdminRequest(String path) {
- super(METHOD.GET, path, SolrRequestType.ADMIN);
+ this(METHOD.GET, path);
Review Comment:
Fixed in df6ed4d. This constructor now defaults to POST.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
