jaykay12 commented on PR #4537:
URL: https://github.com/apache/solr/pull/4537#issuecomment-5381144688

   > Can you remind me what we needed this PR as a follow up to #4452? It looks 
better, but I can't quite remember what the issue was that we had in 4452 that 
made us decide to punt it...
   
   hey @epugh yes, this suggestion to use Interface this way came from your 
suggestion: https://github.com/apache/solr/pull/4452#discussion_r3314008365 
which I tried incorporating in the PR: https://github.com/apache/solr/pull/4452 
but i faced some issue related to v2 API not getting registered correctly & me 
getting 404. 
   
   https://github.com/apache/solr/pull/4452#issuecomment-4606416964 -> then we 
decided to take those delta changes to a follow-up PR, which is this one now. 
   
   That 404 issue got fixed after addressing this suggestion by copilot: 🚀 
https://github.com/apache/solr/pull/4537#discussion_r3789973260
   
   
   > Also @jaykay12 can you fix the changelog entry?
   
   yes, @epugh have fixed it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to