adityamparikh commented on PR #159: URL: https://github.com/apache/solr-mcp/pull/159#issuecomment-5357774209
Reviewed this as part of a sweep over the open PRs. The alias tools look well-built — blank-input validation, `AliasResult` registered in `SolrNativeHints`, a Testcontainers integration test, and MCP hints that match what each tool does (`readOnlyHint` on list, `destructiveHint` on delete). Those are easy things to miss and they're all here. **First: the three red native checks are almost certainly not your code.** I fetched the branch to check rather than guess — it forked from `582490b` (2026-06-19) and contains neither `2809af2` nor `9e71cb4`, the two native-image fixes that landed on `main` on 2026-08-18. Native was broken on `main` for everyone before those. A rebase onto current `main` should clear them, and is worth doing before anyone reads those failures as a problem with alias management. Two suggestions, both small: **`AliasResult` uses `java.util.Date`.** The other tool responses use `Instant` — `CollectionCreationResult` and `SolrHealthStatus` both do. Switching would also let you drop the `@JsonFormat` pattern, since `Instant` already serialises as ISO-8601. **`createAlias` takes collections as a comma-separated `String`.** That maps directly onto SolrJ's signature, which is presumably why it's shaped that way — but the caller here is an LLM, and a `List<String>` removes the "does whitespace after the comma matter?" question entirely. Joining with `,` before handing off to `CollectionAdminRequest.createAlias` keeps the SolrJ call unchanged. This also matches the direction #164 is taking with typed sort clauses. Neither is blocking. The rebase is the thing worth doing first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
