VishnuPriyaChandraSekar commented on code in PR #4626:
URL: https://github.com/apache/solr/pull/4626#discussion_r3809358525
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java:
##########
@@ -301,7 +301,7 @@ private HttpClient createHttpClient(Builder builder) {
asyncTracker.getMaxRequestsQueuedPerDestination());
httpClient.setUserAgentField(new HttpField(HttpHeader.USER_AGENT,
USER_AGENT));
httpClient.setConnectTimeout(builder.getConnectionTimeoutMillis());
- httpClient.setIdleTimeout(-1); // don't enforce an idle timeout at this
level
+ httpClient.setIdleTimeout(SolrHttpConstants.DEFAULT_SO_TIMEOUT);
Review Comment:
@dsmiley Could you provide me an example to help me to understand this
better
> We want to make it possible to choose a longer idle timeout in the
builder, I'd think. If a longer one is chosen, it won't work; it'll be
effectively capped at this amount. On the other hand...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
