dsmiley commented on PR #4643: URL: https://github.com/apache/solr/pull/4643#issuecomment-5308328263
> One caveat worth stating against this PR, not for it. ClosedChannelException is not a reliable signal of a transient peer failure. Right. I'm -1 on checking ClosedChannelException on wasCommError (was this PR is doing) because I believe the intent of that method is to ascertain if the request was submitted or not. That exception isn't a reliable indicator. Nonetheless I think we can improve retry-ability separately from exception inspection. I filed https://issues.apache.org/jira/browse/SOLR-18341 and https://issues.apache.org/jira/browse/SOLR-18343 You are welcome to take them on if you like. There may be other ways ... like by checking if the payload has been transmitted yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
