renatoh commented on PR #4655: URL: https://github.com/apache/solr/pull/4655#issuecomment-5293618071
> Also the change (that I introduced RE executor initialization) results in no enforced cap/limit on threads. I didn't check if there's one at the JDK HttpClient level. If there's no limit, then it's worth a major-changes-since adoc file note. We should probably have a bit of javadoc somewhere to communicate whatever limit may or may not exist so at least users know. If there's no limit, IMO it's fine. It's straight-forward for a user to enforce via a semaphore if they wish. @dsmiley I have added some documentation. I've noticed for the HttpJdkSolrClient.executor, we have an attribute on the builder, the user can pass in his own executor if he needs different settings. But we do not have that for httpClientExecutor. I think it would make sense to add it to the builder, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
