gerlowskija commented on code in PR #4731:
URL: https://github.com/apache/solr/pull/4731#discussion_r3776264954
##########
solr/core/src/test/org/apache/solr/DisMaxRequestHandlerTest.java:
##########
@@ -137,19 +137,18 @@ public void doTestSomeStuff(final String qt) {
assertQ(
"boost query",
- req("q", "cool stuff", "qt", qt, "bq", "subject:hell^400"),
+ reqWithPath(qt, "q", "cool stuff", "bq", "subject:hell^400"),
"//*[@numFound='3']",
"//result/doc[1]/str[@name='id'][.='666']",
"//result/doc[2]/str[@name='id'][.='42']",
"//result/doc[3]/str[@name='id'][.='8675309']");
assertQ(
"multi boost query",
- req(
+ reqWithPath(
+ qt,
Review Comment:
Yeah good thought - if I do eventually succeed in getting 'qt' removed then
variable names like this won't make any sense.
OTOH, renaming this variable (and others like it) will make the diff much
less homogeneous. Right now every line in this diff is a req -> reqWithPath
swap. But if you as a reviewer don't mind adding that noise to the diff (?),
then I don't either I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
