janhoy commented on code in PR #4711: URL: https://github.com/apache/solr/pull/4711#discussion_r3727614804
########## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ########## Review Comment: Problem was that it was impossible to distinguish if the -1 was because the JVM did not expose cpu usage or because wrong metric name was used. Have added a separate test for whether cpu is available at all, and now assert that `liveCPUUsage()` returns >0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
