dsmiley commented on code in PR #4712: URL: https://github.com/apache/solr/pull/4712#discussion_r3723900853
########## gradle/testing/coverage.gradle: ########## Review Comment: can you please convert this to kotlin? ########## gradle/testing/coverage.gradle: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// This adds jacoco code coverage to test tasks, along with an aggregated +// coverage report for all projects. + +// Coverage is opt-in: tests run with the jacoco agent only if the 'coverage' +// task is explicitly requested or -Ptests.coverage=true is passed. +def withCoverage = gradle.startParameter.taskNames.any { + it == "coverage" || it.endsWith(":coverage") +} || Boolean.parseBoolean(propertyOrDefault("tests.coverage", "false")) Review Comment: I would prefer we do this check in settings.gradle to conditionally include coverage.gradle. It'd skip loading this whole file and skip a large "if withCoverage" check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
