serhiy-bzhezytskyy commented on PR #4632: URL: https://github.com/apache/solr/pull/4632#issuecomment-4954832464
Moving the tests into `ConcurrentUpdateSolrClientTestBase` (so they run for both clients) surfaced a real bug on the Jetty client: it coalesces several queued updates into a single `<stream>` request, so a failed batch was only reporting the **first** update's documents — the rest were lost silently. The JDK client sends one request per update, so it was already fine. The fix: `doSendUpdateStream` now returns the response together with the updates it actually sent (`SentStream`), and the error handler is invoked for every affected update, not just the first one in the coalesced batch. On the Jetty side the `OutStream` — which already is the batch boundary — now owns the updates coalesced into it, rather than tracking them in a parallel list. A handler that throws on one update is logged and doesn't stop the others or the runner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
