renatoh opened a new pull request, #4628: URL: https://github.com/apache/solr/pull/4628
@janhoy Following up on the discussion on https://github.com/apache/solr/pull/4606, I simplified the creation of URLs by moving from StringBuilder to the more flexible StringJoiner. I had to change the signature of the public method StrUtils.partialURLEncodeVal, since it was couple to a StringBuilder, now it returns the encodedUrl rather than adding it to the passed in StringBuilder, which is more flexible. Not sure if I can just change the signature of such a method or if I need to keep old method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
