dsmiley commented on code in PR #4569:
URL: https://github.com/apache/solr/pull/4569#discussion_r3532967169
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -640,16 +640,23 @@ def verifySrcUnpacked(java, artifact, unpackPath,
version, testArgs):
print(' %s' % line.strip())
raise RuntimeError('source release has WARs...')
- validateCmd = './gradlew --no-daemon check -p solr/documentation'
+ logDir = '%s/build' % unpackPath
+ os.makedirs(logDir, exist_ok=True)
+
+ validateCmd = './gradlew rat'
+ print(' run "%s"' % validateCmd)
+ java.run_java(validateCmd, '%s/rat.log' % logDir)
+
Review Comment:
run "rat". It was surprising we weren't already running this tool in the
smoketester given it's role.
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -981,7 +988,7 @@ def make_java_config(parser):
parser.error('JAVA_HOME must be set')
if cygwin:
java_home = subprocess.check_output('cygpath -u "%s"' % java_home,
shell=True).decode('utf-8').strip()
- cmd_prefix = 'export JAVA_HOME="%s" PATH="%s/bin:$PATH"
JAVACMD="%s/bin/java"' % \
+ cmd_prefix = 'export JAVA_HOME="%s" PATH="%s/bin:$PATH"
JAVACMD="%s/bin/java" GRADLE_OPTS="-Dorg.gradle.daemon=false"' % \
Review Comment:
I set the gradle daemon setting here to remove the repetitiveness above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
