Serhiy Bzhezytskyy created SOLR-18296:
-----------------------------------------

             Summary: Upgrade google-java-format to 1.35.0 (fixes JDK 24/25 
build break)
                 Key: SOLR-18296
                 URL: https://issues.apache.org/jira/browse/SOLR-18296
             Project: Solr
          Issue Type: Task
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Serhiy Bzhezytskyy


Solr's spotless/tidy pins google-java-format 1.18.1 (gradle/libs.versions.toml).
That version calls javac internals — 
Log$DeferredDiagnosticHandler.getDiagnostics() — whose signatures changed in 
JDK 24, so `gradlew tidy` / `spotlessApply` throws NoSuchMethodError on JDK 
24+. google-java-format 1.34.0+ adds support for the newer JDKs; 1.35.0 is the 
current release.

This bumps google-javaformat 1.18.1 -> 1.35.0. The Java baseline is unchanged 
(JDK 21); this only affects the spotless code formatter.

Scope:
- gradle/libs.versions.toml: google-javaformat 1.18.1 -> 1.35.0
- re-running the formatter (`gradlew tidy`) reformats ~35 files (minor, 
mechanical — the new version's formatting rules)
- spotless (8.3.0) drives the new formatter version with no other change

Verified on Eclipse Temurin 21 and JDK 25: `gradlew spotlessJavaCheck` passes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to