janhoy commented on code in PR #4534:
URL: https://github.com/apache/solr/pull/4534#discussion_r3426809963
##########
solr/webapp/web/js/angular/controllers/security.js:
##########
@@ -412,6 +412,12 @@ solrAdminApp.controller('SecurityController', function
($scope, $timeout, $cooki
return false;
}
+ var username = $scope.upsertUser.username ?
$scope.upsertUser.username.trim() : "";
+ if (password === username) {
+ $scope.validationError = "Password must not be the same as the username";
+ return false;
+ }
Review Comment:
This is a fair comment. For operators who wish to disable the rule
long-term, it makes sense for the UI to also respect this. Now that the HTTP
call made by the UI will fail with HTTP 400, the user will be alerted through
the normal error-message mechanism of the UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
