mattiasbpersson opened a new pull request, #832:
URL: https://github.com/apache/solr-operator/pull/832
## Description
Adds `global.imagePullSecrets` support to the solr-operator helm chart
deployment.
The existing `image.imagePullSecret` field is rendered inside `containers[]`
in the deployment template, which is not a valid Kubernetes pod spec field.
Kubernetes silently ignores it, so pull secrets are never applied to the
operator pod. This makes it impossible to deploy the solr-operator from a
private registry.
This PR adds `global.imagePullSecrets` at the pod spec level
(`spec.template.spec.imagePullSecrets`), consistent with how the solr helm
chart already handles it.
Supports both formats:
- Kubernetes-native: `[{name: "my-secret"}]`
- Plain strings: `["my-secret"]`
## Changes
- `values.yaml` — Added `global.imagePullSecrets` default
- `templates/deployment.yaml` — Render `imagePullSecrets` at pod spec level
- `Chart.yaml` — Changelog entry
- `README.md` — Documentation entry
## Related
- Closes #338
- Supersedes #343 (stale since 2021, original author inactive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
