gerlowskija commented on PR #4461:
URL: https://github.com/apache/solr/pull/4461#issuecomment-4547275216

   IMO deprecation was the right decision here.
   
   I gather from some of the discussion on SOLR-17715 that there were some 
wrinkles, the `SolrClient.query` method overloads being a tough sticking point 
in particular.  But IMO those are solve-able problems.  Potential workarounds 
for that:
   
   - give SolrClient a `protected QueryRequest createQueryRequest(...)` that 
folks can extend if they want to customize how QueryRequests are constructed in 
these syntax-sugar methods
   - give SolrClient getters/setters or builder-methods to control the 
'default' query and update endpoints used by `query(...)`, `add(...)`, etc. 
   - offer users a new SolrClient implementation that wraps/delegates to an 
existing client except for taking and using "default" query and update endpoints
   
   Hopefully one of those approaches would be palatable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to