[
https://issues.apache.org/jira/browse/SOLR-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069479#comment-18069479
]
ASF subversion and git services commented on SOLR-17857:
--------------------------------------------------------
Commit aa2e32da881aa6aafcfa82cdb079f79ea4855f23 in solr's branch
refs/heads/branch_10x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=aa2e32da881 ]
SOLR-17857: SolrMetricsContext is now reliably closed (#4226)
SolrMetricsContext is now AutoCloseable; renamed unregister() to close().
Ensure it is closed exactly once, fixing double-close of OTEL metrics
that yielded warnings. Uses ObjectReleaseTracker.
Key changes:
- PluginBag tracks all plugins (V1, V2, and defaults) in allPlugins,
ensuring proper cleanup during replacement and shutdown.
- RequestHandlerBase asserts that initializeMetrics() is called before
handling requests, preventing memory leaks from untracked contexts.
- InfoHandler and SchemaHandler initialize metrics on dynamically-created
sub-handlers, registering them for cleanup.
- SolrFieldCacheBean: fix recursive close; removed from core metrics.
- HighlightComponent: fix unclosed context due to improper
default/aliasing in SolrCore.loadSearchComponents.
- CoreContainer.shutdown: shut down coreZkRegister executor early so
in-progress async reloads (triggered by ZK config watchers) complete
before cores are closed.
- ObjectReleaseTracker: add a way to inspect contents. Sadly one test
needs to ignore certain unclosed contexts: MissingSegmentRecoveryTest
Co-authored-by: Houston Putman <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
> Investigate potential memory leaks from OTEL metrics
> ----------------------------------------------------
>
> Key: SOLR-17857
> URL: https://issues.apache.org/jira/browse/SOLR-17857
> Project: Solr
> Issue Type: Sub-task
> Reporter: Matthew Biscocho
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There was a memory leak from gauges in SOLR-13677
> We should do some testing and investigation that this issue hasn't resurfaced
> with the migration to OTEL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
