dsmiley commented on PR #4236: URL: https://github.com/apache/solr/pull/4236#issuecomment-4129625684
> I guess this is only tangentially related, but there has to be a simpler way of doing all of this, right? ... I thought I communicated this elsewhere but I agree and I think we shouldn't add a semaphore. I believe Dat basically ported what Apache HttpClient was doing over to Jetty HttpClient, including very questionably recreating some limits that Apache HttpClient natively had over to Jetty HttpClient which didn't have an identical limit. (Disclaimer: I could be mis-understanding!) IMO we should lean on whatever the HttpClient of choice is naturally offering us. If it has some sort of limit, cool. If not, that's cool too -- deal with it. Don't introduce new limits, or at the very least, default them off. CC @magibney -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
