mlbiscoc commented on code in PR #4226:
URL: https://github.com/apache/solr/pull/4226#discussion_r2975819899
##########
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##########
@@ -139,7 +139,7 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
coreAdminAsyncTracker.expensiveExecutor =
solrMetricsContext.instrumentedExecutorService(
coreAdminAsyncTracker.expensiveExecutor,
- "solr_node_executor",
+ "solr_node_expensive_executor",
Review Comment:
I wouldn't say this is right or wrong I guess just preference how we want to
show this. `solr_node_executor` is just the prefix but the executor has
attribute `name` to that actually groups what executor this metric was tracking.
```
# HELP solr_node_executor_thread_pool_tasks Thread pool task counts
# TYPE solr_node_executor_thread_pool_tasks gauge
solr_node_executor_thread_pool_tasks{category="ADMIN",name="asyncCoreAdminExecutor",otel_scope_name="org.apache.solr",type="active"}
0.0
solr_node_executor_thread_pool_tasks{category="ADMIN",name="asyncCoreExpensiveAdminExecutor",otel_scope_name="org.apache.solr",type="active"}
0.0
```
to now
```
# HELP solr_node_executor_thread_pool_tasks Thread pool task counts
# TYPE solr_node_executor_thread_pool_tasks gauge
solr_node_executor_thread_pool_tasks{category="ADMIN",name="asyncCoreAdminExecutor",otel_scope_name="org.apache.solr",type="active"}
0.0
# HELP solr_node_executor_thread_pool_tasks Thread pool task counts
# TYPE solr_node_expensive_executor_thread_pool_tasks gauge
solr_node_expensive_executor_thread_pool_tasks{category="ADMIN",name="asyncCoreExpensiveAdminExecutor",otel_scope_name="org.apache.solr",type="active"}
0.0
```
We now create 2 separate metrics. I personally liked it how it was before
since it was grouped and differentiated by name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
