dsmiley commented on code in PR #4193:
URL: https://github.com/apache/solr/pull/4193#discussion_r2956928829
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkMaintenanceUtils.java:
##########
@@ -345,13 +342,6 @@ public FileVisitResult visitFile(Path file,
BasicFileAttributes attrs)
filenameExclusions);
return FileVisitResult.CONTINUE;
}
- if (isFileForbiddenInConfigSets(filename)) {
Review Comment:
> it should just go in ConfigSetService
This PR does in fact move some forbidden file type config into there from
ZkMaintenanceUtils. But ultimately the ConfigSetService implementations must
use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
