[ 
https://issues.apache.org/jira/browse/SOLR-18130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066362#comment-18066362
 ] 

David Smiley commented on SOLR-18130:
-------------------------------------

It's available, yes (it's unassigned).  The changes would _unlikely_ mention 
Zookeeper CSP or CSPs in general -- it's about the right use of overloaded 
constructors of CloudSolrClient.Builder, which internally uses CSP but that's 
an implementation detail.  Perhaps this issue should introduce a new utility 
method that can take a string and figure out if it's a list of HTTP URLs, or if 
it's not and thus assumed a ZK with the trailing chroot.  I've seen a need for 
this utility method at work to allow for convenient single code path ways of 
instantiating the client from a configurable string that might be either of 
these patterns.

> CloudSolrStream should not depend on ZooKeeper
> ----------------------------------------------
>
>                 Key: SOLR-18130
>                 URL: https://issues.apache.org/jira/browse/SOLR-18130
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ, streaming expressions
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev
>
> In the SolrJ streaming expressions module, CloudSolrStream depends on 
> ZooKeeper, and thus so does its subclasses (DrillStream, TopicStream, 
> ShuffleStream, ParallelStream).  It's a runtime dependency, triggered by a 
> "zkHost" parameter that's supplied to {{SolrClientCache#getCloudSolrClient}} 
> that uses {{CloudSolrClient.Builder}} that uses reflection to try to load 
> {{ZkClientClusterStateProvider}}.
> I propose renaming these parameters in the module from zkHost to maybe 
> "quorumHosts" that could either be list of Solr HTTP (when it starts with 
> "http:" or "https:") or ZK if not.   This should bring about a new 
> well-deserved constructor to CloudSolrClient.Builder to parse a string, as 
> it's not a matter specific to streaming expressions.  This would be very 
> convenient to callers I've seen elsewhere.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to