janhoy commented on code in PR #4209:
URL: https://github.com/apache/solr/pull/4209#discussion_r2943495910


##########
solr/core/src/java/org/apache/solr/metrics/OtelRuntimeJvmMetrics.java:
##########
@@ -65,6 +75,38 @@ public ContextPropagators getPropagators() {
             // TODO: We should have this configurable to enable/disable 
specific JVM metrics
             .enableAllFeatures()
             .build();
+    java.lang.management.OperatingSystemMXBean osMxBean =
+        ManagementFactory.getOperatingSystemMXBean();
+    if (osMxBean instanceof com.sun.management.OperatingSystemMXBean 
extOsMxBean) {
+      systemMemoryTotalGauge =
+          solrMetricManager.observableLongGauge(
+              registryName,
+              "jvm.system.memory",

Review Comment:
   Oh, well, I managed to enable OTLP export of metrics, I thought it was not 
possible. So guess changing from underscore to dot in 10.1 would be a break, 
unless we classify it as a bug or a BETA feature..
   <img width="1028" height="833" alt="Skjermbilde 2026-03-17 kl  00 08 48" 
src="https://github.com/user-attachments/assets/23c3dbc5-9964-4a52-9e45-8ff6df2fe83b";
 />
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to