Copilot commented on code in PR #4213:
URL: https://github.com/apache/solr/pull/4213#discussion_r2942201198
##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementConfig.java:
##########
@@ -40,14 +40,14 @@ public class AffinityPlacementConfig implements
PlacementPluginConfig {
*
* <p>Nodes on which this system property is not defined are considered
being in the same
* Availability Zone {@link #UNDEFINED_AVAILABILITY_ZONE} (hopefully the
value of this constant is
- * not the name of a real Availability Zone :).
+ * not the name of a real Availability Zone :) ).
Review Comment:
Javadoc now has an extra closing parenthesis and spacing (`:) ).`), which
reads like a typo and makes the sentence grammatically incorrect. Consider
reverting to the previous punctuation (e.g., `:).`).
##########
solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java:
##########
@@ -284,7 +284,7 @@ public BalancePlan computeBalancing(
break;
}
}
- // For now we do not have any way to see if there are out-of-date notes
in the middle of the
+ // For now, we do not have any way to see if there are out-of-date notes
in the middle of the
Review Comment:
Comment says "out-of-date notes" but it appears to be referring to nodes in
the TreeSet. This looks like a typo; consider changing "notes" to "nodes" for
clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
