dsmiley commented on code in PR #4195:
URL: https://github.com/apache/solr/pull/4195#discussion_r2936759379
##########
dev-docs/lucene-upgrade.md:
##########
Review Comment:
Remember the discussion thread about a Lucene upgrade that includes a Codec
update, and needing to broadcast this fact in the upgrade notes page? This
markdown file should explicitly add this step.
##########
solr/core/src/java/org/apache/solr/schema/ScalarQuantizedDenseVectorField.java:
##########
@@ -76,6 +75,10 @@ public ScalarQuantizedDenseVectorField(
public void init(IndexSchema schema, Map<String, String> args) {
this.bits =
ofNullable(args.remove(BITS_PARAM)).map(Integer::parseInt).orElse(DEFAULT_BITS);
+ // Retain parsing of these ("compress", "confidenceInterval") legacy Solr
10 schema params for
+ // compatibility even though
+ // Lucene 10.4's scalar-quantized vector format no longer consumes them
directly. They are no-op
+ // going forward.
Review Comment:
Then maybe lets mark the params deprecated with a version param of 10.1
##########
solr/core/src/java/org/apache/solr/schema/ScalarQuantizedDenseVectorField.java:
##########
@@ -76,6 +75,10 @@ public ScalarQuantizedDenseVectorField(
public void init(IndexSchema schema, Map<String, String> args) {
this.bits =
ofNullable(args.remove(BITS_PARAM)).map(Integer::parseInt).orElse(DEFAULT_BITS);
+ // Retain parsing of these ("compress", "confidenceInterval") legacy Solr
10 schema params for
+ // compatibility even though
+ // Lucene 10.4's scalar-quantized vector format no longer consumes them
directly. They are no-op
+ // going forward.
Review Comment:
Also, use the DeprecationLog so that the user sees a warning if they provide
these params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
