[ 
https://issues.apache.org/jira/browse/SOLR-17550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley resolved SOLR-17550.
---------------------------------
    Resolution: Invalid

bq. The key "node" should exist with the node name as value but instead the key 
is itself the node name

For the code path in question, surprisingly the "node" key is not even 
considered.  When "persist" is false, the semantics of the message appears to 
be to trigger overseer prioritization, and *not* to "addrole".  Shrug.

> preferred Overseer might not work
> ---------------------------------
>
>                 Key: SOLR-17550
>                 URL: https://issues.apache.org/jira/browse/SOLR-17550
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev, pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> By code inspection, ZkController.setPreferredOverseer creates a command 
> message improperly.  The key "node" should exist with the node name as value 
> but instead the key is itself the node name – a bug introduced by a 
> refactoring in 2022.
> Ideally we understand the ramifications; like shouldn't this be found by a 
> test?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to