HoustonPutman commented on code in PR #4069:
URL: https://github.com/apache/solr/pull/4069#discussion_r2934188305
##########
solr/core/src/test/org/apache/solr/cloud/LeaderVoteWaitTimeoutTest.java:
##########
@@ -284,6 +284,15 @@ public void testMostInSyncReplicasCanWinElection() throws
Exception {
waitForState("Timeout waiting for 1x3 collection", collectionName,
clusterShape(1, 3));
assertDocsExistInAllReplicas(Arrays.asList(leader, replica1),
collectionName, 1, 3);
+
+ try (ZkShardTerms zkShardTerms =
Review Comment:
this would have actually failed before this PR. So we are fixing a case
where zkShardTerms can fail to be set to the leader term after "recovery" (in
this case peer-sync).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
