malliaridis commented on PR #4154: URL: https://github.com/apache/solr/pull/4154#issuecomment-3993049921
> Should this be /cluster/nodes/live and we also support /cluster/nodes which would return all? @epugh consider using only `GET /cluster/nodes` and add a query parameter so that we are following a more "RESTful" approach. E.g. you may add the query parameter `status` a single node status or `statuses` that accepts multiple statuses of nodes (not sure if `statuses` is common wording?). This way, we have a single endpoint for the same resource, and add the option to reuse it by applying filters via query parameters. Ofcourse other parameters could also make sense, like `active` (boolean) for filtering all active states, rather than listing them all individually. But since we are talking about a new API endpoint that is added, maybe it makes sense to create a separate PR? Don't want to block you though from proceeding wth this one. Besides that I went quickly over the changes, overall it looks fine to me (taking into account all the previous conversation), but I haven't tested it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
