VishnuPriyaChandraSekar commented on code in PR #4162:
URL: https://github.com/apache/solr/pull/4162#discussion_r2850171870
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -73,11 +73,16 @@ public abstract class BaseHttpClusterStateProvider
implements ClusterStateProvid
Executors.newSingleThreadScheduledExecutor(
new SolrNamedThreadFactory("liveNodeReloadingExecutor"));
- protected void initConfiguredNodes(List<String> solrUrls) throws Exception {
+ protected void initConfiguredNodes(List<String> solrUrls) {
this.configuredNodes =
solrUrls.stream()
.map(BaseHttpClusterStateProvider::stringToUrl)
.collect(Collectors.toList());
+ if
(this.configuredNodes.stream().map(URL::getProtocol).collect(Collectors.toSet()).size()
Review Comment:
Got it :) hopefully, user don't provide mixed protocols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
