janhoy commented on code in PR #4111:
URL: https://github.com/apache/solr/pull/4111#discussion_r2830396673
##########
.github/scripts/validate-changelog-yaml.py:
##########
@@ -120,6 +123,12 @@ def validate_changelog_yaml(file_path):
print(f"::error file={file_path}::Field 'issues' value
{data['issues']} points to a non-existing github PR. Did you intend to
reference a JIRA issue, please use 'links'.")
return False
+ # Validate that comments are removed
+ for not_allowed in not_allowed_text:
+ if not_allowed in raw_content:
+ print(f"::error file={file_path}::File still contains
commented template text. Please remove the comment block at the top of the
file.")
Review Comment:
I added this check to the changelog checker so we get warning in PR if
comments are not removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
