malliaridis commented on code in PR #4037:
URL: https://github.com/apache/solr/pull/4037#discussion_r2675750150
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -333,29 +336,33 @@ class RenderJavadocTask extends DefaultTask {
opts << '-linksource'
}
opts << '-use'
- opts << [ '-locale', 'en_US' ]
- opts << [ '-windowtitle', title ]
- opts << [ '-doctitle', title ]
+ opts << ['-locale', 'en_US']
+ opts << ['-windowtitle', title]
+ opts << ['-doctitle', title]
if (!classpath.isEmpty()) {
- opts << [ '-classpath', classpath.asPath ]
+ opts << ['-classpath', classpath.asPath]
}
- opts << [ '-bottom', "<i>Copyright © 2000-${project.buildYear} Apache
Software Foundation. All Rights Reserved.</i>" ]
-
- opts << [ '-tag', 'lucene.experimental:a:WARNING: This API is experimental
and might change in incompatible ways in the next release.' ]
- opts << [ '-tag', 'lucene.internal:a:NOTE: This API is for internal
purposes only and might change in incompatible ways in the next release.' ]
- opts << [ '-tag', "lucene.spi:t:SPI Name (case-insensitive: if the name is
'htmlStrip', 'htmlstrip' can be used when looking up the service)." ]
-
- opts << [ '-doclet', "org.apache.lucene.missingdoclet.MissingDoclet" ]
- opts << [ '-docletpath', docletpath.asPath ]
- opts << [ '--missing-level', javadocMissingLevel ]
+ opts <<
+ ['-bottom', "<i>Copyright © 2000-${project.buildYear} Apache
Software Foundation. All Rights Reserved.</i>"]
+
+ opts <<
+ ['-tag', 'lucene.experimental:a:WARNING: This API is experimental and
might change in incompatible ways in the next release.']
+ opts <<
+ ['-tag', 'lucene.internal:a:NOTE: This API is for internal purposes
only and might change in incompatible ways in the next release.']
+ opts <<
+ ['-tag', "lucene.spi:t:SPI Name (case-insensitive: if the name is
'htmlStrip', 'htmlstrip' can be used when looking up the service)."]
Review Comment:
I personally like it if the opening parentheses / brackets are on the same
line and the content then goes to the next line, with the closing parentehses
at the last new line. Like
```groovy
opts << [
'-tag', 'lucene.experimental:a:WARNING: This API is experimental and might
change in incompatible ways in the next release.'
]
opts <<
['-tag', 'lucene.experimental:a:WARNING: This API is experimental and
might change in incompatible ways in the next release.']
```
But it is a personal preference and takes more lines of code.
##########
gradle/hacks/global-exclude-dependencies.gradle:
##########
@@ -38,16 +38,19 @@ allprojects { prj ->
JavaPlugin.TEST_COMPILE_CLASSPATH_CONFIGURATION_NAME,
JavaPlugin.TEST_RUNTIME_CLASSPATH_CONFIGURATION_NAME
]
- configurations.matching { it.name in configNames }.all {
+ configurations.matching {it.name in configNames}.all {
exclude group: 'log4j', module: 'log4j' // use SLF4j
exclude group: "ch.qos.logback" // use SLF4j
exclude group: 'commons-logging', module: 'commons-logging' // use SLF4j
exclude group: 'com.google.code.findbugs', module: 'jsr305' // Uses GPL
license
- exclude group: 'com.google.code.findbugs', module: 'annotations' // Use
Spotbugs Annotations as replacement
- exclude group: 'javax.annotation', module: 'javax.annotation-api' //
Replaced with jakarta.annotation-api
+ exclude group: 'com.google.code.findbugs', module: 'annotations'
+ // Use Spotbugs Annotations as replacement
+ exclude group: 'javax.annotation', module: 'javax.annotation-api'
+ // Replaced with jakarta.annotation-api
exclude group: 'org.slf4j', module: 'slf4j-log4j12' // don't include log4j
1.x
exclude group: 'org.apache.yetus', module: 'audience-annotations' // Don't
need annotations
- exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
// Don't need annotations
+ exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
+ // Don't need annotations
Review Comment:
Auto-formatting puts trailing comments below, but I think it is better if
they are above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
