dsmiley commented on code in PR #4038:
URL: https://github.com/apache/solr/pull/4038#discussion_r2678912280
##########
solr/solrj-jetty/build.gradle:
##########
@@ -52,50 +50,25 @@ dependencies {
testImplementation project(':solr:solrj-jetty')
// ZK dependencies for tests
- testImplementation project(':solr:solrj-zookeeper')
+ testRuntimeOnly project(':solr:solrj-zookeeper')
permitTestUnusedDeclared project(':solr:solrj-zookeeper')
Review Comment:
Is this line necessary? I don't think cutterslade enforces runtimeOnly
declared dependencies because it has no way of knowing. Therefore use of
"permit" blah blah for such a dependency is pointless.
##########
solr/solrj-jetty/build.gradle:
##########
@@ -52,50 +50,25 @@ dependencies {
testImplementation project(':solr:solrj-jetty')
// ZK dependencies for tests
- testImplementation project(':solr:solrj-zookeeper')
+ testRuntimeOnly project(':solr:solrj-zookeeper')
permitTestUnusedDeclared project(':solr:solrj-zookeeper')
- testImplementation(libs.apache.zookeeper.zookeeper, {
+ testRuntimeOnly(libs.apache.zookeeper.zookeeper, {
Review Comment:
Is this necessary? If you add solrj-zookeeper, it should bring in zookeeper
transitively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
