dsmiley commented on code in PR #4039:
URL: https://github.com/apache/solr/pull/4039#discussion_r2678757433
##########
gradle/maven/defaults-maven.gradle:
##########
@@ -148,6 +148,38 @@ configure(subprojects.findAll { it.path in
rootProject.published }) { prj ->
artifact javadocJar
pom(configurePom)
+
+ // Remove the internal :platform dependency from
dependencyManagement in POMs
+ pom.withXml {
+ def root = asNode()
+ def depMgmt = root.dependencyManagement
+ if (depMgmt) {
+ depMgmt.each { dmNode ->
+ def deps = dmNode.dependencies
+ if (deps) {
Review Comment:
Minor syntax recommendation but I love Groovy's elvis operator. Using it
would remove an indentation level (lowering cyclomatic complexity) while
keeping null-safety. Same above at depMgmt. I used to write a lot of Groovy
back in the day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
