dsmiley commented on code in PR #4010:
URL: https://github.com/apache/solr/pull/4010#discussion_r2670998786
##########
solr/core/src/test/org/apache/solr/handler/TestStressThreadBackup.java:
##########
@@ -81,9 +81,7 @@ public static void beforeClass() {
}
@AfterClass
- public static void afterClass() {
- System.clearProperty("solr.security.allow.paths");
- }
+ public static void afterClass() {}
Review Comment:
remove
##########
solr/core/src/test/org/apache/solr/schema/ManagedSchemaRoundRobinCloudTest.java:
##########
@@ -54,9 +54,7 @@ public static void setupCluster() throws Exception {
}
@AfterClass
- public static void clearSysProps() {
- System.clearProperty("managed.schema.mutable");
- }
+ public static void clearSysProps() {}
Review Comment:
remove
##########
solr/core/src/test/org/apache/solr/metrics/SolrMetricsIntegrationTest.java:
##########
@@ -100,7 +100,6 @@ public void testZkMetrics() throws Exception {
new MiniSolrCloudCluster.Builder(3, createTempDir())
.addConfig("conf", configset("conf2"))
.configure();
- System.clearProperty("metricsEnabled");
Review Comment:
I liked this line as it showed the limited scope of impact of when/where the
property had an effect.
##########
solr/core/src/test/org/apache/solr/highlight/TestUnifiedSolrHighlighterWithoutStoredId.java:
##########
@@ -29,8 +29,5 @@ public static void beforeClassProps() {
}
@AfterClass
- public static void afterClassProps() {
- System.clearProperty("solr.tests.id.stored");
- System.clearProperty("solr.tests.id.docValues");
- }
+ public static void afterClassProps() {}
Review Comment:
remove
##########
solr/core/src/test/org/apache/solr/handler/component/InfixSuggestersTest.java:
##########
@@ -44,6 +44,10 @@ public static void beforeClass() throws Exception {
@Test
public void test2xBuildReload() throws Exception {
Review Comment:
weird difference. Can't we just leave this test alone?
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java:
##########
@@ -53,6 +53,13 @@ public static void setUpClass() {
System.setProperty("distribUpdateSoTimeout", "5000");
}
+ @Override
+ public void distribSetUp() throws Exception {
+ super.distribSetUp();
+ // Enable fuzzy comparison to handle floating-point precision differences
in distributed queries
+ flags = FUZZY;
Review Comment:
interesting addition.
##########
solr/core/src/test/org/apache/solr/schema/SchemaVersionSpecificBehaviorTest.java:
##########
@@ -306,7 +306,6 @@ public IndexSchema initCoreUsingSchemaVersion(final float
ver) throws Exception
"Schema version not set correctly", String.valueOf(ver),
String.valueOf(s.getVersion()));
return s;
} finally {
- System.clearProperty("solr.schema.test.ver");
Review Comment:
left an empty finally block
##########
solr/core/src/test/org/apache/solr/highlight/TestUnifiedSolrHighlighter.java:
##########
@@ -43,13 +43,7 @@ public static void beforeClass() throws Exception {
}
@AfterClass
- public static void afterClass() {
- System.clearProperty("filterCache.enabled");
- System.clearProperty("queryResultCache.enabled");
- System.clearProperty("documentCache.enabled");
- System.clearProperty("solr.tests.id.stored");
- System.clearProperty("solr.tests.id.docValues");
- }
+ public static void afterClass() {}
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
