[ 
https://issues.apache.org/jira/browse/SOLR-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18050484#comment-18050484
 ] 

ASF subversion and git services commented on SOLR-18033:
--------------------------------------------------------

Commit 4d616b46cd0d5e6ec4d6cb7af11c37ec6541180a in solr's branch 
refs/heads/jira/SOLR-17975 from Chris M. Hostetter
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=4d616b46cd0 ]

Fix LateInteractionVectorField and uncomment failing test asserts that can now 
pass if SOLR-18033.patch is applied


> binary based fields can't control their external based representation
> ---------------------------------------------------------------------
>
>                 Key: SOLR-18033
>                 URL: https://issues.apache.org/jira/browse/SOLR-18033
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-18033-1.patch, SOLR-18033.patch
>
>
> This was discovered while working on SOLR-17975:
> {quote}... the main issue i *HAVE* found is that even though FieldType has 
> method(s) for converting internal BytesRef's into something type specific 
> that can be returned to the client, SolrDocumentFetcher isn't consistently 
> using those methods in all useDocValuesAsStored situations ... it's got it's 
> own special case statement with specialized conditionals that would need to 
> be rethought/refactored to ensure the BINARY DocValues for this new field 
> type (and any other similar field types) can be reconstituted back into 
> _whatever_ external representation _[...the field type wants to use...]_
> {quote}
> While working on a patch with tests for this, I discovered that the same 
> problem exists for stored fields due to hardcoded logic in DocsStreamer -- 
> even though {{FieldType}} has a distinct  {{void 
> write(TextResponseWriter,...}}} method (for when the response format requires 
> String-ification) distinct from the {{Object toObject(IndexableField)}} 
> (designed for use by the javabincodec) {{DocStreamer}} only uses {{toObject}} 
> with a hardcoded list of special classes -- otherwise it uses the very old 
> {{String toExternal(IndexableField)}} method



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to