epugh commented on code in PR #4023:
URL: https://github.com/apache/solr/pull/4023#discussion_r2666214523
##########
solr/solr-ref-guide/modules/deployment-guide/pages/backup-restore.adoc:
##########
@@ -396,6 +396,39 @@ Any children under the `<repository>` tag are passed as
additional configuration
Information on each of the repository implementations provided with Solr is
provided below.
+=== Parallel File Transfers
+
+Backup and restore operations can transfer multiple index files in parallel to
improve throughput, especially when using cloud storage repositories like S3 or
GCS where latency is higher.
+The parallelism is controlled via system properties or environment variables:
+
+`solr.backup.maxParallelUploads`::
Review Comment:
solr.backup.maxparalleluploads ?
##########
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##########
@@ -52,6 +64,15 @@
*/
public class IncrementalShardBackup {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ /**
+ * Maximum number of files to upload in parallel during backup. Can be
configured via the system
+ * property {@code solr.backup.maxParallelUploads} or environment variable
{@code
+ * SOLR_BACKUP_MAX_PARALLEL_UPLOADS}.
+ */
+ private static final int DEFAULT_MAX_PARALLEL_UPLOADS =
+ EnvUtils.getPropertyAsInteger("solr.backup.maxParallelUploads", 1);
Review Comment:
Good use of EnvUtils, we need them everywhere.
##########
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##########
@@ -52,6 +64,15 @@
*/
public class IncrementalShardBackup {
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ /**
+ * Maximum number of files to upload in parallel during backup. Can be
configured via the system
+ * property {@code solr.backup.maxParallelUploads} or environment variable
{@code
+ * SOLR_BACKUP_MAX_PARALLEL_UPLOADS}.
+ */
+ private static final int DEFAULT_MAX_PARALLEL_UPLOADS =
+ EnvUtils.getPropertyAsInteger("solr.backup.maxParallelUploads", 1);
Review Comment:
The pattern we are using now is dot cased, so
`solr.backup.maxparalleluploads`, or maybe if we had mulitple properties
`solr.backup.parraleluploads.max`....
##########
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##########
@@ -154,8 +175,8 @@ protected IncrementalShardSnapshotResponse backup(final
IndexCommit indexCommit)
solrCore.getSolrConfig().indexConfig.lockType);
try {
BackupStats stats = incrementalCopy(files, dir);
- details.indexFileCount = stats.fileCount;
- details.uploadedIndexFileCount = stats.uploadedFileCount;
+ details.indexFileCount = stats.fileCount.get();
Review Comment:
Never mind, I see the AtomicInteger!
##########
solr/core/src/java/org/apache/solr/handler/IncrementalShardBackup.java:
##########
@@ -154,8 +175,8 @@ protected IncrementalShardSnapshotResponse backup(final
IndexCommit indexCommit)
solrCore.getSolrConfig().indexConfig.lockType);
try {
BackupStats stats = incrementalCopy(files, dir);
- details.indexFileCount = stats.fileCount;
- details.uploadedIndexFileCount = stats.uploadedFileCount;
+ details.indexFileCount = stats.fileCount.get();
Review Comment:
why the .get()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
