isaric commented on code in PR #4011:
URL: https://github.com/apache/solr/pull/4011#discussion_r2664824463
##########
solr/core/src/java/org/apache/solr/core/RequestParams.java:
##########
@@ -130,7 +132,9 @@ public RequestParams setParams(String name, ParamSet
paramSet) {
Map p = (Map) deepCopy.get(NAME);
if (p == null) deepCopy.put(NAME, p = new LinkedHashMap<>());
if (paramSet == null) p.remove(name);
Review Comment:
I agree that in Java conditionals should always use curly braces for
clarity. This is the existing code that was not changed in my PR.
I am hesitant to change it as I am not sure if there is a convention
regarding this practice in the project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
