malliaridis commented on code in PR #4009:
URL: https://github.com/apache/solr/pull/4009#discussion_r2663931556
##########
solr/distribution/build.gradle:
##########
@@ -27,12 +27,16 @@ plugins {
ext {
releaseDir = file("${buildDir}/release")
- withSignedArtifacts = { ->
+ withSignedArtifacts = {
+
+ ->
Review Comment:
Interesting to so that this is a valid format. 🤔
##########
gradle/globals.gradle:
##########
@@ -104,10 +104,10 @@ allprojects {
// that one still tries to write something when the other closed
// the underlying output stream.
def wrapped = new java.io.FilterOutputStream(output) {
- public void close() {
- // no-op. we close this stream manually.
- }
- }
+ public void close() {
+ // no-op. we close this stream manually.
+ }
+ }
Review Comment:
I believe there is some kind of inconsistency here with the spaces. We have
6 spaces indentation for some reason here, I believe a result of two different
rules with different indentation. Is this expected?
Plus, I believe the closing curly bracket should be on the same indentation
as the line that contains the opening bracket?
##########
gradle/documentation/render-javadoc.gradle:
##########
@@ -316,14 +321,23 @@ class RenderJavadocTask extends DefaultTask {
outputDir.mkdirs();
def opts = []
- opts << [ '-overview', project.file("${srcDirs[0]}/overview.html") ]
- opts << [ '-sourcepath', srcDirs.join(File.pathSeparator) ]
- opts << [ '-subpackages', 'org.apache.solr' ]
- opts << [ '-d', outputDir ]
+ opts << [
+ '-overview',
+ project.file("${srcDirs[0]}/overview.html")
+ ]
+ opts << [
+ '-sourcepath',
+ srcDirs.join(File.pathSeparator)
+ ]
+ opts << [
+ '-subpackages',
+ 'org.apache.solr'
+ ]
Review Comment:
I'm curious what rule was applied here that caused the line breaks. It
doesn't look like max line length to me, as we are under 50 characters in some
of these lines. I would assume "chop down arrays when more than 1" would be the
rule here, but it did not format the values below.
##########
gradle/generation/javacc.gradle:
##########
@@ -66,14 +66,14 @@ def commonCleanups = { FileTree generatedFiles ->
// Add CharStream imports.
text = text.replaceAll(
/package (.+)/,
-'''package $1
+ '''package $1
import javax.annotation.processing.Generated;
import org.apache.lucene.queryparser.charstream.CharStream;'''.trim())
text = text.replace(
- "/** Token Manager. */",
-'''/** Token Manager. */
+ "/** Token Manager. */",
+ '''/** Token Manager. */
@Generated("JavaCC")'''
- )
+ )
Review Comment:
This part does not look very consistent, one case has the closing
parentheses at the end, the other in a new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
