[
https://issues.apache.org/jira/browse/SOLR-18055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048982#comment-18048982
]
ASF subversion and git services commented on SOLR-18055:
--------------------------------------------------------
Commit 6699580057af8c37bd34cd45f3f13aa480865581 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=6699580057a ]
HttpShardHandlerFactory urlScheme -- use sys prop for default (#4008)
HttpShardHandlerFactory reads the urlScheme from configuration, defaulting to
"http" if there is none. Most/all solr.xml's we have, especially for tests,
have this explicitly configured with urlScheme sys prop resolution. I think the
factory should read that sys prop as a default, at least as a small
improvement. This way, test JettySolrRunner stuff can start Solr in SSL mode
without needing a solr.xml.
Fixes DistributedDebugComponentTest and possibly more.
SolrTestCaseJ4: don't use constants from ZkTestReader inappropriately.
The affected lines are likely to be superseded by SOLR-18055
> Use SOLR_SSL_ENABLED to auto-set urlScheme appropriately
> --------------------------------------------------------
>
> Key: SOLR-18055
> URL: https://issues.apache.org/jira/browse/SOLR-18055
> Project: Solr
> Issue Type: Improvement
> Components: security
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
>
> A user uses SOLR_SSL_ENABLED to enable https / SSL. It ought to be enough
> but today it isn't. For standalone mode, the solr.xml
> httpShardHandlerFactory has a urlScheme to manually set. I propose it need
> not; that component can examine solr.ssl.enabled prop to choose between http
> and https as a default. For SolrCloud, ZkStateReader.getBaseUrlForNodeName
> can do similarly, as the default if the urlScheme cluster property isn't set.
> CloudSolrClient can do the same if someone sets the system property. Thus a
> SolrCloud user need not feel compelled to set the urlScheme in a cluster
> property, which is an annoying step. That might eventually be deprecated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
