epugh commented on code in PR #4008: URL: https://github.com/apache/solr/pull/4008#discussion_r2659725962
########## solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java: ########## @@ -17,8 +17,6 @@ package org.apache.solr; import static java.util.Objects.requireNonNull; -import static org.apache.solr.common.cloud.ZkStateReader.HTTPS; -import static org.apache.solr.common.cloud.ZkStateReader.URL_SCHEME; Review Comment: That is an unfortunant coincidence, and it would be great to rename them to be more explciit, it's just so easy to get them confused, if we can't outright eliminate this.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
