janhoy commented on code in PR #3593:
URL: https://github.com/apache/solr/pull/3593#discussion_r2658601816
##########
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java:
##########
@@ -92,6 +93,9 @@ public class S3StorageClient {
/** The S3 bucket where we read/write all data. */
private final String bucketName;
+ /** The HTTP client used by the S3 client. Needs to be closed separately. */
+ private final SdkHttpClient httpClient;
Review Comment:
Claude helped me rewrite the class to manage httpClient lifecycle explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
