janhoy commented on PR #3945:
URL: https://github.com/apache/solr/pull/3945#issuecomment-3705570243
I like the suggestion about a property to disable all Docker tests. I think
that could be a valuable addition to the test framework, but I'd suggest
treating it as a separate task that can be developed independently of this
PR/issue.
My preference is to keep the platform-specific fix here for a few reasons:
1. **Clarity**: The current approach makes it explicit why the test is being
skipped—there's a direct connection to the failing test. A general Docker ban
in Jenkins for a platform would be less targeted and thus more hidden and might
be forgotten once the underlying issue is resolved. We have other platform
specific test modifiers elsewhere for Windows/Mac, nothing new there.
2. **Complexity of a generic solution**: I investigated whether
TestContainers could handle this more elegantly, but unfortunately it doesn't
provide a clean way to fail early when an image doesn't exist for the current
platform/architecture. What happened before we disabled it was that it would
pull the linux/amd64 image and attempt to execute it—failing only after the
wrong image had already been downloaded.
There are potential generic approaches, but none are straightforward:
* A test utility class that inspects the Docker image manifest to check
for platform support
* Querying the local Docker engine for the current platform and using
`cmd.withPlatform()` to force the correct image (though this might be too
strict for legitimate platform variants like linux/arm/v7 vs linux/arm64/v8)??
* Waiting for Tika to actually listen on the port before declaring
readiness (still wastes time on the image download)
Good news: Tika has accepted my PR, so the next Tika release should provide
multi-arch images, allowing us to remove this workaround entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
