[
https://issues.apache.org/jira/browse/SOLR-18044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048663#comment-18048663
]
Gus Heck commented on SOLR-18044:
---------------------------------
I'm going to focus this filter on things that are essential to proper
functioning of Solr, and make sure every single thing included also has a
comment as to why it's essential. I think the tracer request attribute can be
managed by a filter that handles tracing however, so I'm now intending to skip
that.
> Add universal request attributes in a servlet filter
> ----------------------------------------------------
>
> Key: SOLR-18044
> URL: https://issues.apache.org/jira/browse/SOLR-18044
> Project: Solr
> Issue Type: Sub-task
> Reporter: Gus Heck
> Priority: Minor
>
> So far I've identified 3 attributes that are unconditionally set at various
> points in SolrDispatchFilter and the constructor for HttpSolrCall. I believe
> we can simplify that constructor and create a single place for setting up
> attributes that are "always available". These attributes are:
> # The tracer (key: REQ_ATTR_TRACING_TRACER )
> # the RTimerTree (key: REQUEST_TIMER_SERVLET_ATTRIBUTE)
> # the CoreContainer (key: org.apache.solr.CoreContainer)
> Other attributes that are set conditionally such as
> `req.setAttribute("org.eclipse.jetty.multipartConfig",
> multipartConfigElement);` probably can't move here so it's not possible to
> corral a full view of what's in our request attributes, but this should
> provide a clear place to add/identify attributes applicable to all requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
