[
https://issues.apache.org/jira/browse/SOLR-16498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18048491#comment-18048491
]
David Smiley commented on SOLR-16498:
-------------------------------------
This is perhaps mostly addressed by
{{org.apache.solr.util.SolrJettyTestRule#getBaseUrl}} which didn't exist when I
filed this. And now more tests are using this rule directly; thanks Eric :-)
The rest could perhaps be addressed with the reborn HttpSolrClient SOLR-17968
which has getBaseURL (ugh, capitalization inconsistency). I'm working on that
one.
> Tests need the URL from a SolrClient; don't require legacy clients
> ------------------------------------------------------------------
>
> Key: SOLR-16498
> URL: https://issues.apache.org/jira/browse/SOLR-16498
> Project: Solr
> Issue Type: Test
> Components: Tests
> Reporter: David Smiley
> Priority: Major
> Labels: newdev
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> SOLR-16368 could not switch many tests away from some legacy/deprecated
> SolrClient classes because they were either getting the URL or Apache
> HttpClient instance out of the client. This issue aims to solve this so that
> our tests don't depend on a legacy client and don't depend on Apache
> HttpClient either. We would prefer a non-dependency approach using [Java
> 11's new
> HttpClient|https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/package-summary.html].
> And we need to figure out how to get the URL from the SolrClient in a more
> general way.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
