Copilot commented on code in PR #3987: URL: https://github.com/apache/solr/pull/3987#discussion_r2649862061
########## solr/core/src/test-files/solr/collection1/conf/solrconfig-test-properties.xml: ########## @@ -0,0 +1,37 @@ +<?xml version="1.0" ?> + +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +<!-- + A minimal solrconfig specifically for testing property substitution functionality. + This config is used by TestConfig.testJavaProperty() to test that system property + substitution works correctly in Solr configuration files. Review Comment: The comment references `TestConfig.testJavaProperty()` but this test method was moved to `TestConfigPropertySubstitution.testJavaPropertySubstitution()` in the new dedicated test class. The comment should be updated to reference the correct test class and method. ```suggestion This config is used by TestConfigPropertySubstitution.testJavaPropertySubstitution() to test that system property substitution works correctly in Solr configuration files. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
