janhoy commented on PR #3980: URL: https://github.com/apache/solr/pull/3980#issuecomment-3690648157
> @janhoy I approved it, but obviosly there are test fixes needed... The thrust of the PR looks great. Let me know if you need additional manual testing. I got XLSXResponsewriter working. But of course there is also `langid` module that uses Tika1.x `LanguageIdentifier`. Tika3 has a completely new `LanguageDetector` API with an `OptimizeLangDetector` implementation quite different from the old Tika detector. I'm doing a shot at switching our `TikaLanguageIdentifierUpdateProcessor` to the new one, and if most existing tests pass, call it a good temporary solution for 9.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
