dsmiley commented on code in PR #3981:
URL: https://github.com/apache/solr/pull/3981#discussion_r2644810171
##########
solr/core/src/java/org/apache/solr/servlet/ServletUtils.java:
##########
@@ -143,9 +143,6 @@ static boolean excludedPath(
for (Pattern p : excludePatterns) {
Matcher matcher = p.matcher(requestPath);
if (matcher.lookingAt()) {
- if (chain != null) {
- chain.doFilter(request, response);
Review Comment:
wow that was a sneaky side-effect of what looked like a simple boolean method
##########
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##########
@@ -67,7 +65,7 @@
// servlets that are more focused in scope. This should become possible now
that we have a
// ServletContextListener for startup/shutdown of CoreContainer that sets up a
service from which
// things like CoreContainer can be requested. (or better yet injected)
-public class SolrDispatchFilter extends HttpFilter implements PathExcluder {
Review Comment:
looks like you can also remove PathExcluder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
