janhoy opened a new pull request, #3978: URL: https://github.com/apache/solr/pull/3978
We have seen examples of changelog yaml files being committed that are syntactically correct but still wrong Currently we check for valid yaml, presence of an `author` and a valid `type`, a `title` etc. This PR will add * Check that either a `links` is a `issues` key is present * If an `issues` key is used, it must be integer and not above 17000 (will catch people trying to put JIRA number in there) * Check that all keys are among the allowed logchange yaml keys, else fail with a message about unknown key * Fail with a different message if `merge_requests` or `configurations` keys are used (valid logchange but we don't support them) This hopefully helps educate contributors and committers alike on the required format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
