Copilot commented on code in PR #3976:
URL: https://github.com/apache/solr/pull/3976#discussion_r2643143963
##########
.github/workflows/docker-nightly.yml:
##########
@@ -0,0 +1,176 @@
+name: Nightly Docker Build & Publish
+
+on:
+ schedule:
+ # Run daily at 2 AM UTC
+ - cron: '0 2 * * *'
+ workflow_dispatch:
+ # Allow manual triggering
+
+jobs:
+ build-and-publish:
+ name: Build and publish Docker images
+ runs-on: ubuntu-latest
+ timeout-minutes: 60
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ # main branch - Gradle on JDK21, Docker images with JRE25
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+
+ # branch_10x - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-jre25'
+
+ # branch_10_0 - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-java25'
+
+ # branch_9x - Gradle on JDK17, Docker images with JRE17 (default)
and JRE21
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: full
+ base-image: eclipse-temurin:17-jre-jammy
+ tag-suffix: ''
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: slim
+ base-image: eclipse-temurin:17-jre-jammy
+ tag-suffix: ''
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: '-java21'
+
+ env:
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.SOLR_DEVELOCITY_ACCESS_KEY }}
+
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v5
+ with:
+ ref: ${{ matrix.branch }}
+
+ - name: Set up Java (JDK ${{ matrix.gradle-jdk }})
+ uses: actions/setup-java@v4
+ with:
+ distribution: temurin
+ java-version: ${{ matrix.gradle-jdk }}
+ java-package: jdk
+
+ - name: Cache gradle-wrapper.jar
+ uses: actions/cache@v4
+ with:
+ path: gradle/wrapper/gradle-wrapper.jar
+ key: gradle-wrapper-${{
hashFiles('gradle/wrapper/gradle-wrapper.jar.sha256') }}
+
+ - name: Set up Gradle
+ uses: gradle/actions/setup-gradle@v4
+ with:
+ develocity-token-expiry: 8
+
+ - name: Create custom gradle.properties
+ run: |
+ cat > gradle.properties << 'EOF'
+ # Disable Gradle daemon for all builds.
+ org.gradle.daemon=false
+
+ # Lucene specific settings for lucene2 build nodes
+ systemProp.file.encoding=UTF-8
+ org.gradle.jvmargs=-Xmx2g -XX:ReservedCodeCacheSize=256m
-XX:TieredStopAtLevel=1 -Dfile.encoding=UTF-8
-Dkotlin.daemon.jvm.options="-Xmx4096M" -XX:+UseParallelGC
-XX:ActiveProcessorCount=1 \
+ --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
Review Comment:
The backslash continuation on line 129 creates a multi-line string with
embedded newlines and spaces that may not work as intended. The
org.gradle.jvmargs property should be a single continuous line or the
continuation should be properly formatted. This could lead to the JVM arguments
not being applied correctly, potentially causing build failures.
##########
.github/workflows/docker-nightly.yml:
##########
@@ -0,0 +1,176 @@
+name: Nightly Docker Build & Publish
+
+on:
+ schedule:
+ # Run daily at 2 AM UTC
+ - cron: '0 2 * * *'
+ workflow_dispatch:
+ # Allow manual triggering
+
+jobs:
+ build-and-publish:
+ name: Build and publish Docker images
+ runs-on: ubuntu-latest
+ timeout-minutes: 60
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ # main branch - Gradle on JDK21, Docker images with JRE25
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+
+ # branch_10x - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-jre25'
+
+ # branch_10_0 - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-java25'
Review Comment:
The tag suffix for branch_10_0 with JRE25 is inconsistent with branch_10x.
For branch_10x line 52, the JRE25 variant uses '-jre25', but for branch_10_0
line 72, it uses '-java25'. This inconsistency in naming could confuse users
and should be standardized to use the same suffix pattern across all branches.
```suggestion
tag-suffix: '-jre25'
```
##########
.github/workflows/docker-nightly.yml:
##########
@@ -0,0 +1,176 @@
+name: Nightly Docker Build & Publish
+
+on:
+ schedule:
+ # Run daily at 2 AM UTC
+ - cron: '0 2 * * *'
+ workflow_dispatch:
+ # Allow manual triggering
+
+jobs:
+ build-and-publish:
+ name: Build and publish Docker images
+ runs-on: ubuntu-latest
+ timeout-minutes: 60
+
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ # main branch - Gradle on JDK21, Docker images with JRE25
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+ - branch: main
+ version: 11.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: ''
+
+ # branch_10x - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10x
+ version: 10.1.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-jre25'
+
+ # branch_10_0 - Gradle on JDK21, Docker images with JRE21 (default)
and JRE25
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: slim
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: ''
+ - branch: branch_10_0
+ version: 10.0.0-SNAPSHOT
+ gradle-jdk: 21
+ dist: full
+ base-image: eclipse-temurin:25-jre-jammy
+ tag-suffix: '-java25'
+
+ # branch_9x - Gradle on JDK17, Docker images with JRE17 (default)
and JRE21
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: full
+ base-image: eclipse-temurin:17-jre-jammy
+ tag-suffix: ''
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: slim
+ base-image: eclipse-temurin:17-jre-jammy
+ tag-suffix: ''
+ - branch: branch_9x
+ version: 9.11.0-SNAPSHOT
+ gradle-jdk: 17
+ dist: full
+ base-image: eclipse-temurin:21-jre-jammy
+ tag-suffix: '-java21'
Review Comment:
The tag suffix for branch_9x with JRE21 is inconsistent with other branches.
For branch_10x and branch_10_0, the JRE25 variants use '-jre25' or '-java25',
but for branch_9x line 92, the JRE21 variant uses '-java21'. This should be
standardized to either use 'jre' or 'java' consistently across all branches
(e.g., '-jre21' to match the '-jre25' pattern).
```suggestion
tag-suffix: '-jre21'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
