janhoy commented on PR #3973: URL: https://github.com/apache/solr/pull/3973#issuecomment-3684096353
Sorry for the back and forth @risdenk, but I want to simplify the solution from the PR yesterday, which tried to suport `SOLR_DOCKER_PLATFORM` for `dockerBuild` and `testDocker`. After seeing how Jenkins docker builds are setup, they run both `testDocker` and `dockerPush` tasks in the same Jenkins step, but that fails now since it complains that build is not supported for multi platform. So I could either split gradle task in Jenkins into a separate `testDocker` and `dockerPush` task or rewrite it as done in this PR. I landed on this simple solution, as I have not so far seen an actual use case for building for multi-arch without also pushing. Such feature could be added (in a different way) later if actually needed. PS: I plan to do CTR on this PR, and trigger a new Jenkins build.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
